search

We-the-People-civ4col-mod / Mod

This is the repository where the mod resides.
89 stars 37 forks source link

Quest "Trade Guns with Europe" shows wrong target number #997

Closed victorxup closed 5 months ago

victorxup commented 7 months ago

In CIV4EventInfos.xml

It shows 2000 guns for normal speed as a goal: image

But as a criteria of achieval 3000 guns is defined instead: image

I suppose the second one is correct.

UPD: The same issue also have at least:

raystuttgart commented 7 months ago

Then simply correct it. :) Why report a bug that is so easy to fix instead of directly fixing it.

victorxup commented 7 months ago

Then simply correct it. :) Why report a bug that is so easy to fix instead of directly fixing it.

  1. For me it's a reasonable point: to know the opinion of team. Which value would be correct, for example.
  2. I've got no access rights to commit to develop))
raystuttgart commented 7 months ago

1) Most likely nobody will answer as hardly anybody is still active except Nightinggale 2) Please get the commit rights then from Nightinggale

--> If we work with throwing tickets the mod is dead.

As Nightinggale will be too busy to take care of it all ... And I currently do not want to be playing nanny anymore for such small things.

Schmiddie1979 commented 6 months ago

I can take a look at it.

Schmiddie1979 commented 6 months ago

Issue is under review. Thanks for reporting.

Nightinggale commented 5 months ago

I'm going to look into redoing the xml layout a bit. Having a design, which relies on multiple event entries containing the same number is just asking for those numbers to go out of sync and then something like this happens.

Schmiddie1979 commented 5 months ago

@raubwuerger

We are wondering if the trade quests are all currently incorrect. I have tested various trade quests and the required number of goods and the number needed to complete the quests do not match in almost all cases.

It's kind of frustrating when the text says that 4000 goods X are required, but then you have to trade 5000 to complete the quest. As I said, it feels like this is the case with almost all quests - so I'm wondering if this is intended or really a bug resp. how it should be and what we might be overlooking.

Might you be able to look at it and provide some feedback?

raubwuerger commented 5 months ago

Is fixed ...

997 Corrected trade event values. The value shown in the quest log is now matching the conclusion value.