search

WeAreFairphone / FP2-Checkup

Other
9 stars 1 forks source link

Releases #2

Closed Rudloff closed 6 years ago

Rudloff commented 6 years ago

How should we number releases? Do we follow upstream and use something like standalone-18.04.1?

Edit: I just saw Fairphone now uses semantic version numbers like 2.1.8 (but don't tag them) so I guess we can use that as well.

Rudloff commented 6 years ago

@Roboe Any opinion on this?

licaon-kter commented 6 years ago

Does this have an actual app activity? I was able to use it via QuickShortcut but I was expecting an icon in the launcher.

I've build at: https://github.com/WeAreFairphone/FP2-Checkup/commit/bb07e6f0bebbe1bac9ad2d59a4bb0d77ce0385f7 maybe I should have used another commit?

Rudloff commented 6 years ago

Which commit did you build? The launcher activity was added here: https://github.com/WeAreFairphone/FP2-Checkup/commit/861f0ea54d76a8ca3b660d29f9b5a2a9a04b5d17#diff-c8cc2dd42271f2bf39c6aa81eb6a5529R52

Roboe commented 6 years ago

@Rudloff Hmmm, I don't really have a preference.

@licaon-kter If you have further unrelated doubts, open a new issue, please.

Rudloff commented 6 years ago

@Roboe I will use the APK version name in tags then, it makes F-Droid packaging easier.

licaon-kter commented 6 years ago

@Rudloff Right, that's better ( https://gitlab.com/fdroid/fdroiddata/merge_requests/3663 )

Regarding F-Droid, I'll remove compile 'com.google.android.gms:play-services-appindexing:8.1.0' in the metadata, is the app still ok?

Rudloff commented 6 years ago

@licaon-kter I did not see that, thanks! The library does not seem to be used anywhere so I removed it.

I would say we are ready for a first release now.

Rudloff commented 6 years ago

I published the 2.1.8 tag: https://github.com/WeAreFairphone/FP2-Checkup/releases/tag/2.1.8