search

WeAreFairphone / flashable-zip_microG

Install microG or UnifiedNlp into an Android system, plus an OTA survival addon.d script
https://github.com/WeAreFairphone/flashable-zip_microG/releases
GNU General Public License v3.0
28 stars 6 forks source link

Add config for unified nlp with gapps #17

Closed greenflash1986 closed 3 years ago

greenflash1986 commented 3 years ago

Hi,

I created a version which allows to have Unified working BESIDE Gapps and integrated the needed RRO and apks into your flashable zip.

Thank you for your work.

Roboe commented 3 years ago

Hi, @greenflash1986! Thanks for sharing your mod.

Unfortunately, I won't merge this. On the bright side, this is an open source project, so you can still develop it in your fork and, in fact, I encourage you to continue doing so. The reason why I can't merge it is because this code is built around a minimal trust principle (F-Droid and MicroG) and your code contains the download of an unsigned binary APK built by a single person. This is nothing personal, though.

On the other hand, it is quite interesting what you did with the package_name configuration. And also good point the ZIP exclusion when packaging the flashable ZIP, haha, :ok_hand:.

If you keep developing your fork of this mod, and you want an advice from me, I'll move the package_name property to the first line of config files, just to let the comment be coherent.

Thanks again for sharing this!

greenflash1986 commented 3 years ago

Hi @Roboe

your concerns are fully understandable. The indentions of this PR were more like a "hello Flashable-Zip, maybe here is some useful code for others, who star this repo and is this repo still alive" than a full "please merge it as production ready".

As this repo is still alive, are there and maybe how are your indentions for the ongoing development?

When I developed this PR I came over the "make-Branch" and thought about using it, but then I've seen that it's to far away from head. But maybe I could make some implementations when I find some time and create a PR. Or I could just do some further development in my own repo. Or do you have another idea? Whats your favorite?

Best regards