search

WeAreFairphone / fprsmap

This is a Leaflet map of the local Fairphoners communities
https://map.fairphone.community
GNU General Public License v3.0
10 stars 7 forks source link

Confusing functions naming #17

Closed Roboe closed 7 years ago

Roboe commented 7 years ago

As commented in #13:

@StefanBrand

Generally the naming of some variables and functions is a bit confusing (getMapOverlays vs getMapLayers for example).

@Roboe

Your semantics arguments are sharp: I had a hard time trying to be coherent with the Leaflet docs (a layer and an overlay are not the same) and English semantics. What alternatives do you suggest for getMapOverlays() and getMapLayers()?

@StefanBrand

Hmmm. We should probably differ between Overlays and BaseLayers. Both of them are layers, so getMapLayers() is correct. Instead layers should be overlays in most of the cases, I guess.