WeAreFairphone / fprsmap

This is a Leaflet map of the local Fairphoners communities
https://map.fairphone.community
GNU General Public License v3.0
10 stars 7 forks source link

Distinguish between layers and overlays, close #17 #24

Closed StefanBrand closed 7 years ago

StefanBrand commented 7 years ago

Please review, if I got everything right.

I didn't understand why getAllOverlays() has a defaultOverlays parameter (e.g. why .reduce has defaultOverlays as initialValue. I think it could be simply {}.)

Roboe commented 7 years ago

The defaultOverlays optional parameter doesn't have too much sense, you are right.

Roboe commented 7 years ago

Ready to merge! I'll fixup that last commit of mineinto yours