Closed Roboe closed 7 years ago
I don't like the raw HTML in the code, but...
Me neither it looks awful! 😖
don't know other way to achieve the same functionality.
Well, we could fetchJSON
another file stored locally.
Also, we'd want to style the popup content, maybe.
Maybe this helps: http://stackoverflow.com/questions/12606141/how-would-i-customise-the-look-and-feel-of-the-leaflet-popup I think that the letters are too big, they should be about the size of the controls, in my opinion.
Another thing: Can we add the marker to the cluster, so it clusters with the other markers?
Well, we could
fetch
another file stored locally.
We can write a template in the HTML file and apply it by JS! That'd be the better, :)
Another thing: Can we add the marker to the cluster, so it clusters with the other markers?
Yes! I forgot about the cluster, sorry.
If we add the HQ marker to the cluster, it gets grouped and it's not open by default, so it jeopardizes the purpose of this PR, :/ If fact, that was the subconscious reason for what I didn't grouped it in the first place.
Hm, maybe we should drop it then.
I'd give the cluster more priority than the open-by-default popup. If the marker is not clustered, it just looks awful.
Am 30.09.2016 um 02:18 schrieb Roberto M.F.:
If we add the HQ marker to the cluster, it gets grouped and it's not open by default, so it jeopardizes the purpose of this PR, :/
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/WeAreFairphone/fprsmap/pull/28#issuecomment-250627951, or mute the thread https://github.com/notifications/unsubscribe-auth/AIiMgRl5Q8yvmXekRKUyATjAu5pexkR1ks5qvFVXgaJpZM4KFUeD.
Ok. Should we leave the Fairphone HQ marker anyway or close the PR and the related issue?
I'd close it and not merge the PR.
As you said in #12:
I think the behaviour is quite known for the mayority of the users So it will probably not make usability worse.
Preview: https://roboe.github.io/fprsmap/
I don't like the raw HTML in the code, but... don't know other way to achieve the same functionality.
Also, we'd want to style the popup content, maybe.