search

WeAreFairphone / fprsmap

This is a Leaflet map of the local Fairphoners communities
https://map.fairphone.community
GNU General Public License v3.0
10 stars 7 forks source link

Collapse layer controls on map move start. Close #27 #37

Closed StefanBrand closed 7 years ago

StefanBrand commented 7 years ago

This should free more of the map view on small screens.

This commit is dependent on PR #36 because it makes use of the collapse() function introduced in Leaflet 1.

Roboe commented 7 years ago

Current layer control on https://stefanbrand.github.io/fprsmap/ only collapses when I click elsewhere. I think this commit is not deployed there, could you merge it to your gh-pages? Code looks clean for me, ;)

StefanBrand commented 7 years ago

I parked it on another branch because the "upgrade to leaflet 1" PR was parked on |gh-pages|. I'll push the commit there.

Ps.: Seems that clicking somewhere collapses layer controls by default in Leaflet >1.

Am 29.12.2016 um 18:21 schrieb Roberto M.F.:

Current layer control on https://stefanbrand.github.io/fprsmap/ only collapses when I click elsewhere. I think this commit is not deployed there, could you merge it to your |gh-pages|? Code looks clean for me, ;)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/WeAreFairphone/fprsmap/pull/37#issuecomment-269662693, or mute the thread https://github.com/notifications/unsubscribe-auth/AIiMgWBNHSMJBWV7QBxNYnOEYPSsfD5Nks5rM-whgaJpZM4LXPxr.

StefanBrand commented 7 years ago

Demo is online. Please test it also on your Fairphone. :)

Am 29.12.2016 um 18:21 schrieb Roberto M.F.:

Current layer control on https://stefanbrand.github.io/fprsmap/ only collapses when I click elsewhere. I think this commit is not deployed there, could you merge it to your |gh-pages|? Code looks clean for me, ;)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/WeAreFairphone/fprsmap/pull/37#issuecomment-269662693, or mute the thread https://github.com/notifications/unsubscribe-auth/AIiMgWBNHSMJBWV7QBxNYnOEYPSsfD5Nks5rM-whgaJpZM4LXPxr.

Roboe commented 7 years ago

Works good on both Android's Webkit (Lightning Browser) and Gecko (Firefox for Android).

Merged!