search

WeAreFairphone / fprsmap

This is a Leaflet map of the local Fairphoners communities
https://map.fairphone.community
GNU General Public License v3.0
10 stars 7 forks source link

Panning left or right leads to parallel worlds #49

Closed StefanBrand closed 7 years ago

StefanBrand commented 7 years ago

Implement maxBounds: http://leafletjs.com/reference.html#map-maxbounds

Roboe commented 7 years ago

What about worldCopyJump instead of bounds? I think it's a better approach. The surface of the world is continuous, after all. Also, we are europeans, but other users might not, and would have another rich culture vision of the world we should respect.

StefanBrand commented 7 years ago

Yeah, that widens our horizon! B-)

That's a better solution!

Am 11.01.2017 um 15:27 schrieb Roberto M.F.:

What about |worldCopyJump| http://leafletjs.com/reference.html#map-worldcopyjump instead of bounds?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/WeAreFairphone/fprsmap/issues/49#issuecomment-271881789, or mute the thread https://github.com/notifications/unsubscribe-auth/AIiMgUFRrnFmVkkpVg7t8wy-mkYJBXegks5rRObCgaJpZM4Lghc2.

Roboe commented 7 years ago

For some reason, GitHub couldn't build my gh-pages branch. It builds fine on local, though.

The page build failed with the following error:

unable to build page. Please try again later.

For information on troubleshooting Jekyll see:

  https://help.github.com/articles/troubleshooting-jekyll-builds

If you have any questions you can contact us by replying to this email.
StefanBrand commented 7 years ago

Works fine here: grafik

Roboe commented 7 years ago

That's the penultimate commit. Span to another world (left or right), you will see it doesn't work

StefanBrand commented 7 years ago

Ok. Well, then "Please try again later." ;)

Roboe commented 7 years ago

I'll open a PR and let them build it on the upstream repo, better