Add Community FP2 layer

WeAreFairphone / fprsmap

This is a Leaflet map of the local Fairphoners communities

https://map.fairphone.community

GNU General Public License v3.0

10 stars 7 forks source link

Add Community FP2 layer #51

Closed Roboe closed 6 years ago

Roboe commented 7 years ago

Issue #16

It should be live at https://roboe.github.io/fprsmap/ soon.

Todo:

Add new destinations since the proof of concept
Add comments at the right side of each coordinates (data/community-fp2.json)
Possibly add the arrow plugin @StefanBrand commented here

StefanBrand commented 7 years ago

The demo doesn't work... Are you sure it's on the correct branch?

Roboe commented 7 years ago

I forgot to push, 😰

Done, ;)

StefanBrand commented 7 years ago

Hi, didn't have time till now to look at it.

For the existing groups, could you enter the same coordinates? E.g the Munich path vertex is a bit off in comparison with the group marker.
Amsterdam should only be the first vertex, but we shouldn't be entering all back-and-forth sendings to and from Amsterdam
Somehow it fells odd to have the vector display by default. Maybe we should exclude it from the default view. What do you think?

Roboe commented 7 years ago

Oopsy! Right, didn't pay much attention when placing coordinates, it was a draft only.
Fine, I felt the same about the Amsterdam's returns.
I think it feels odd because of the last-position marker missing in the groups. But yeah, excluding it (and invoking it via URL parameters when needed) seems like a good idea for me :ok_hand:.

I'm quite busy these days, I can't put so much time on the map, :/

StefanBrand commented 6 years ago

I think this has lost relevance / is too hard to maintain and I would like to close it. I'm sorry about it because of the time you put into it. 😕 Are you fine with closing this PR?

Roboe commented 6 years ago

Sure, no problem. Thanks for asking, though, :relaxed: