WeAreFairphone / fprsmap

This is a Leaflet map of the local Fairphoners communities
https://map.fairphone.community
GNU General Public License v3.0
10 stars 7 forks source link

Show physical touch points / shops on the map #56

Closed StefanBrand closed 7 years ago

StefanBrand commented 7 years ago

The csv files for the physical touch points are up! :D -> 3b25cfe874cebc16cadf7fe1d69fe785f58b5ae1

I wonder though, how we will make use of them. Maybe using something like https://github.com/lastlegion/anyToJSON ?

StefanBrand commented 7 years ago

I'm having an issue here: The csv files don't have coordinates, so I implemented ESRI's Geocoding service. Problem is that the process is awfully slow!

Demo: https://stefanbrand.github.io/fprsmap/

StefanBrand commented 7 years ago

I have written a script for node.js that reads in the csv, geocodes them and puts out a json file for us to process. Unfortunately not all addresses are recognized as yet, so some markers aren't on the correct locations...

Roboe commented 7 years ago

Awesome! I'll review it soon. DId you update the node.js script? It would be great to have a look at it, too

StefanBrand commented 7 years ago

Haha, I did it already 3 months ago, but never uploaded it. A demo of the result (the geocoded shops) can be found here:

https://stefanbrand.github.io/fprsmap/

Two of them, in the middle of Germany, have nothing or undefined as popup content... -- This message was sent from my Fairphone 1 with K-9 Mail.

Am 16. Mai 2017 22:47:08 MESZ schrieb "Roberto M.F." notifications@github.com:

Awesome! I'll review it soon. DId you update the node.js script? It would be great to have a look at it, too

StefanBrand commented 7 years ago

DId you update the node.js script? It would be great to have a look at it, too

node.js script is here: https://github.com/WeAreFairphone/fpShopsGeoCoder 🙂

Awesome! I'll review it soon.

It's not perfect yet, but the critical issues are ironed out. The content of the shops' popups could get some more attention (e.g. opening hours?). See: https://github.com/StefanBrand/fprsmap/

StefanBrand commented 7 years ago

Opening hours are added too: https://github.com/StefanBrand/fprsmap/commit/fb2cc088e8b0b021b9f6d8b1dfc932dd8d0b626d :)

I'm going to create a PR.