WeAreFairphone / fprsmap

This is a Leaflet map of the local Fairphoners communities
https://map.fairphone.community
GNU General Public License v3.0
10 stars 7 forks source link

Add all 2018 Munich events #75

Closed Ingo-FP-Angel closed 6 years ago

Ingo-FP-Angel commented 6 years ago

As requested

StefanBrand commented 6 years ago

There is an issue with indentation. YAML files are very picky in this regard. Please fix the indentation in the file.

PS.: You can test your commits by going to Settings in your repository and scrolling down to the Github Pages section. The map will be published to the link in the green box.

grafik

grafik

This is the direct URL to your current version of the map: https://ingo-fp-angel.github.io/fprsmap/ As you can see, the map does not contain any events.

When you hit F12 in Firefox and go to Console, you should see a TypeError underlaid in red. The TypeError's message indicates that there is something wrong with the json.list. Github Pages converts the YAML content of the events.json file to json content. This, of course, only works when the YAML file is properly indented.

Ingo-FP-Angel commented 6 years ago

Ok, done and checked that it works

StefanBrand commented 6 years ago

Great! I merged the two commits into one using git rebase -i HEAD~2 and then prefixing the second commit with fixup so that it got merged into the earlier commit.

Thanks for your contribution, @Ingo-FP-Angel !