search

WeAreFairphone / fprsmap

This is a Leaflet map of the local Fairphoners communities
https://map.fairphone.community
GNU General Public License v3.0
10 stars 7 forks source link

Zoom plus center params and fix initial embed code #92

Closed Ingo-FP-Angel closed 5 years ago

Ingo-FP-Angel commented 5 years ago

Fixes #71 and implements #45

StefanBrand commented 5 years ago

Wow, thanks for your acitivity lately! Makes me want to jump in too. :))

Ingo-FP-Angel commented 5 years ago

Yeah, CURRENTDATE was marked as unused in my IDE so I applied the - in German - Pfadfinderregel to leave the place more clean than I found it. The agenda.json indeed does not contain past events.

I'll look into the getQueries() remark.

Ingo-FP-Angel commented 5 years ago

I forgot to extend the Readme to describe the new query params. Will do it tomorrow.

StefanBrand commented 5 years ago

Ah, good one! 😅 -- Diese Nachricht wurde von meinem Fairphone mit K-9 Mail gesendet.

Am 18. September 2019 18:59:02 MESZ schrieb Ingo-FP-Angel notifications@github.com:

I forgot to extend the Readme to describe the new query params. Will do it tomorrow.

Ingo-FP-Angel commented 5 years ago

Together with the Readme updated I also fixed a bug I introduced (in case no layers were given as query parameter initially).

Ingo-FP-Angel commented 5 years ago

At some point we could look into filling the address bar with the current query parameters too.

Very nice idea! Was easy to implement, too ;-)

Ingo-FP-Angel commented 5 years ago

The way I implemented it is to replace the current history, i.e. you'd be back to DuckDuckGo after one click.

StefanBrand commented 5 years ago

Wow, very cool! :D Great, thank you!!!