search

WeAreFairphone / modem_zip_generator

Scripts to generate a flashable ZIP file with the latest Fairphone modem firmware
MIT License
14 stars 6 forks source link

Overriding recipe warnings on "make build" when FWUPDATE_* equals OTA_* variables #16

Open htgoebel opened 4 years ago

htgoebel commented 4 years ago

When running "make install", I get these warnings:

Makefile:88: warning: overriding recipe for target 'updates/19.11.2-sibon-24df0be9-ota.zip' Makefile:82: warning: ignoring old recipe for target 'updates/19.11.2-sibon-24df0be9-ota.zip'

Roboe commented 2 years ago

@htgoebel Thanks for bringing this up.

This happens because the two OTA upgrade packages the script need are the same at the time (here and here). This makes two make targets at the lines you mention to have the same filename, so make needs to override one of them.

Since it's essentially the same recipe and the package satisfies the two different uses in this case (sourcing the Edify binary and the different firmware images), I'm sure there's no functional problem at all and the message can be discarded. I'm guessing the warning messages don't impede the Makefile running fine and generating the modem ZIP correctly, though; if that's the case, please indicate your OS and make versions.

Any other way, it's an aesthetic problem. I don't have the immediate knowledge or time to solve it, but if anyone does, we'll apreciate a proposition to fix it. Just reply here!