Closed scalp42 closed 5 years ago
I've been test driving this with Chef, looking good but we're not using roles (due to https://github.com/hashicorp/consul/issues/5221#issuecomment-491162829) so YMMV
Feel free to review @pierresouchay
Thanks for the review @pierresouchay. PR is updated with suggested changes.
@scalp42 rubocop has been upgraded, hence the not-working linting. I fixed it: https://github.com/WeAreFarmGeek/diplomat/commit/3f9465c0ba20e7ad60c788f78fa13dd24970636e
Please re-push force, it should work next time
Done.
Consul 1.5.0 introduced a number of changes (https://github.com/hashicorp/consul/blob/master/CHANGELOG.md#150-may-08-2019):
AccessorID
andSecretID
(need valid UUIDs though)Diplomat::Role
is added here)This PR fixes the issue #195.
I'll open an issue for
ACL Auth Method HTTP API
andACL Binding Rule HTTP API
support but it won't be covered in this PR as I don't have access to a k8s cluster right now.Please do not merge this PR until
WIP
is removed from subject as testing is in progress.Thanks for reviewing it @pierresouchay 🇫🇷