search

WeAreFarmGeek / diplomat

A HTTP Ruby API for Consul
BSD 3-Clause "New" or "Revised" License
370 stars 116 forks source link

Unable to use multiple tags when querying for services #212

Closed jebentier closed 3 years ago

jebentier commented 3 years ago

Right now for example Diplomat::Health.service allows the passing of a tag option to filter the results from Consul. But this only accepts a single string today. It would be nice to be able to pass this an array of strings so that you can pass multiple tags that are all required to exist on the registered service for it to be returned by Consul. Consul's API supports this through specifying the tag query parameter multiple times.

If others feel like this is worth while, I'd be more than happy to put together a PR for the enhancement.

pierresouchay commented 3 years ago

@jebentier Sure, feel free to submit a PR!

jebentier commented 3 years ago

@pierresouchay That is great to hear, I've gone ahead and created PR #213