Closed Sapr0 closed 3 years ago
@Sapr0 First of all: thanks a lot for this amazing contribution, pushing a lot the level of details.
I have just a few concerns:
Thanks a lot for the contribution, I'll have a deeper look tomorrow (it is midnight here :-)
Regards
Hi @pierresouchay
I've lowered the gem version to 2.5.0 as you wanted to match the ruby version.
Do you think it could be possible to minimize a bit the minimum versions bump?
Only faraday
got bumped from 1.0.1 to 1.3.0
deep_merge
already had a lose dependency via >= 1.0.1
I've removed json_pure
, because the diplomat gem already had a requirement of ruby >= 2.0 so it would never install this gem
The rest are development dependencies, they are not taken into account when you install this gem.
Addresses issue #214