search

WeAreNewt / re-meme

An app that allows users to post ‘original content’ and other users can ‘remix’ that content by adding in additional elements to the "original content" as a base.
https://rememe.lol
Other
23 stars 8 forks source link

Footer on mobile is too crowded #215

Open 0xjim opened 2 years ago

0xjim commented 2 years ago

May need to switch to a hamburger menu

Image

ibkay998 commented 2 years ago

Hamburger menu for footer not very common. I could try restructuring it and changing the font size to make it more UI friendly.

diegoprudencios commented 2 years ago

IMO we should adapt the design depending on the view size.. something like this:

Screenshot 2022-09-26 at 09 19 12

Figma file: https://www.figma.com/file/wXczUcc9WlLtpuVJmHVYZm/Memixer---Fixes-1?node-id=1797%3A4242

ibkay998 commented 2 years ago

This makes sense when you said hamburger menu what came to mind was click and drop menu. I could use media queries to get this done

ibkay998 commented 2 years ago

made the neccessary changes Screenshot (287) Screenshot (289) Screenshot (288)

ibkay998 commented 2 years ago

I am new to open source i saw that you use bots to automate pull requests mine seems to have failed some of the checks

diegoprudencios commented 2 years ago

This looks good.

I have 3 more topics about the footer.

  1. Can we use something like 64px below the footer, to avoid letting it too close to the edge of the view?

    Screenshot 2022-09-28 at 11 44 40

  2. Let's use the same padding on the left and right sides. We can use 40px.

    Screenshot 2022-09-28 at 11 51 04

  3. Can we use more space between the links? 32px is enough.

ibkay998 commented 2 years ago

Fixed the margin bottom and padding left and padding right Screenshot (290)

ibkay998 commented 2 years ago

just seeing the third change Screenshot (293)