WeAreSnook / human-services

Extensions proposed by the English Local Government Association (LGA) and the local government OpenCommunity project to the OpenReferral standard for human services data. Schema generator code is given to express the schema in various formats. Data conversion routines to make it conform to the standard. API that serves the data in a format compliant with the standard.
0 stars 1 forks source link

Render correct logos on front end app (store em in CMS?) #134

Closed kingdomlevel closed 3 years ago

kingdomlevel commented 3 years ago

Curious about your thoughts on this one - Ananda has sent me on the new logos (as .svg) so we should render these on the page (dark logo for header, light logo for footer).

I think they should probably come from the CMS in case there are updates down the line, but maybe that is overkill + we could just store em in the front end assets?

If it's in the CMS, it won't be hard to add a new image field to the footer and a new image field to (probably) the menu.

kingdomlevel commented 3 years ago

This work in PR #62

kingdomlevel commented 3 years ago

Curious about your thoughts on this one - Ananda has sent me on the new logos (as .svg) so we should render these on the page (dark logo for header, light logo for footer).

I think they should probably come from the CMS in case there are updates down the line, but maybe that is overkill + we could just store em in the front end assets?

If it's in the CMS, it won't be hard to add a new image field to the footer and a new image field to (probably) the menu.

Discussed with Yemi + Ananda, we're just storing them in the front end assets!