search

WeAreTech / wearetech.io

This is wearetech.io
Mozilla Public License 2.0
7 stars 2 forks source link

Add bodyParser.urlencoded middleware #30

Closed telis93 closed 9 years ago

telis93 commented 9 years ago

I think this fixes issue #10.

The problem was that the bodyParser.urlencoded middleware wasn't included so the registration form wasn't being parsed and the req.body variable was empty.

kbariotis commented 9 years ago

Hmm ic. I have already added that configuration on my branch #13 that it fully replaces and extends the current registration process.

You can fork it and check how is working and what we are trying to do. It has some bugs though.

thanpolas commented 9 years ago

Thank you @telis93!

telis93 commented 9 years ago

@thanpolas What about what @stakisko said? Is my commit really necessary?

thanpolas commented 9 years ago

That was a bug in nodeON which i fixed there, it is required anyway beyond the registration process...

We'll conflict but that's hiw we roll =)

On Sunday, November 9, 2014, Aristotelis Dossas notifications@github.com wrote:

@thanpolas https://github.com/thanpolas What about what @stakisko https://github.com/stakisko said? Is my commit really necessary?

— Reply to this email directly or view it on GitHub https://github.com/WeAreTech/wearetech.io/pull/30#issuecomment-62301234.

Thanasis Polychronakis

http://thanpol.as

telis93 commented 9 years ago

Then I suppose #10 can close?

thanpolas commented 9 years ago

Yup

On Sunday, November 9, 2014, Aristotelis Dossas notifications@github.com wrote:

Then I suppose #10 https://github.com/WeAreTech/wearetech.io/issues/10 can close?

— Reply to this email directly or view it on GitHub https://github.com/WeAreTech/wearetech.io/pull/30#issuecomment-62301534.

Thanasis Polychronakis

http://thanpol.as