Migrate to TypeScript - Githubissues

WeAreWizards / passopolis-extensions

Continuation of the extensions code for mitro

GNU General Public License v3.0

81 stars 14 forks source link

Migrate to TypeScript #34

Open teh opened 8 years ago

teh commented 8 years ago

The current extension is really hard to change as witnessed by my attempts to fix the Firefox extension.

In order to re-gain some control I'd like to migrate the code base to ts as mentioned here:

http://www.pgbovine.net/migrating-legacy-codebase-to-typescript.htm

amenk commented 7 years ago

What is hard to change about it?

amenk commented 7 years ago

What is the status? Is that the webpack branch?

teh commented 7 years ago

The webpack branch was the first atetmpt but I got told that firefox won't allow packed extensions so this is a no-go. The source needs to be as-is.

I haven't figured out the best way forward, but after experimenting with both TS and flow (https://flow.org/en/). I believe it will be more productive use flow because flow can infer more on its own and therefore requires fewer type annotations.

amenk commented 7 years ago

I don't have experience with both. But it would be good to come to a state where it is easier to contribute soon :-)

kfrancis commented 7 years ago

I'd push for TS, myself, though I have more experience with that world.

amenk commented 7 years ago

@kfrancis can you help out :-) ?

kfrancis commented 7 years ago

YES!

teh commented 7 years ago

@kfrancis That's great news! Please use whatever makes you most productive and happy. Any change we push will impact a few thousand people, so I'd like to keep code review in place. I can see the following options:

You work on your fork and submit PRs to this repo
I make you a contributor, but we lock down he master branch

Do you have any preference?

amenk commented 7 years ago

@kfrancis Are you still interested in helping out? In case we go for flow, would you also be able to help out with flow migration?

I think we should decide for one framework as soon as possible :-) The good thing with flow is, that @teh already put some effort in this... But I am also okay with TypeScript (I do not have much clue of both worlds..)