search

WeAreWizards / passopolis-server

Server component of Passopolis (formerly Mitro)
GNU General Public License v3.0
79 stars 16 forks source link

Device verification email contains request IP #9

Closed Gautier closed 9 years ago

Gautier commented 9 years ago

This is covering issue #7 and also needs https://github.com/WeAreWizards/passopolis-mail-queue/pull/1

teh commented 9 years ago

Assuming you tested this LGTM - nice about being careful about the update path (field there, not there).

Gautier commented 9 years ago

I have manually tested the Haskell part and the Java part is covered by unit test (and manually debugging output during development) but I haven't tested them together in a production-like environment.

When it goes live it would need to be immediately tested by registering a new user and device and checking the notification.

I can own the deployment + testing if you're cool with that (and if I manage to get the nixops gods with me).

Gautier commented 9 years ago

The previous comment isn't all correct actually. The Java code merely gets exercised by the tests, there are no asserts regarding the extra field. It was only tested using debugging output during development.