search

WeCodePixels / theia-sticky-sidebar

Glues your website's sidebars, making them permanently visible while scrolling.
MIT License
569 stars 209 forks source link

Unstable with DFP tags #7

Closed kugaevsky closed 9 years ago

kugaevsky commented 9 years ago

Thanks for great plugin!

It's really hard to get this error, but sometimes DFP iframe ads are removed from page after theia initialization. I have inner containers with theiaStickySidebar class, but it doesn't help. Could you fix it or just give me an advice when I should initialize theia before or after fetching the ads?

liviucmg commented 9 years ago

Hmm, that sounds odd. Are you sure the inner container has the theiaStickySidebar class? If it does, then no DOM elements should be moved around, so the iframes should remain intact.

moiseslagos commented 9 years ago

I have the same problem, as I fix??? please help me!

liviucmg commented 9 years ago

Be sure you have the inner containers with class="theiaStickySidebar" right inside your sidebar.

moiseslagos commented 9 years ago

Thx so much!

Móises Lagos PachasDiseñador Gráfico - Web, FrontendTelf.: 963849113Facebook: /moises.lagospachas

Date: Wed, 2 Sep 2015 13:09:43 -0700 From: notifications@github.com To: theia-sticky-sidebar@noreply.github.com CC: moises180688@hotmail.com Subject: Re: [theia-sticky-sidebar] Unstable with DFP tags (#7)

Be sure you have the inner containers with class="theiaStickySidebar" right inside your sidebar.

— Reply to this email directly or view it on GitHub.

liviucmg commented 9 years ago

Let me know if it fixed your issue so I can close this. :) Cheers!

moiseslagos commented 9 years ago

I agregge div class ="theiaStickySidebar" --->

With that solved the problem. Without this class "theiaStickySidebar", the blocks did not include me DFP tags. I had not considerardo add that class, because I worked the same, but when adding the DFP did not work Problema resuelto, Saludos desde Perú

Móises Lagos PachasDiseñador Gráfico - Web, FrontendTelf.: 963849113Facebook: /moises.lagospachas

Date: Wed, 2 Sep 2015 13:23:12 -0700 From: notifications@github.com To: theia-sticky-sidebar@noreply.github.com CC: moises180688@hotmail.com Subject: Re: [theia-sticky-sidebar] Unstable with DFP tags (#7)

Let me know if it fixed your issue so I can close this. :) Cheers!

— Reply to this email directly or view it on GitHub.

liviucmg commented 9 years ago

Awesome, glad it helped! The reason is works is because without the "theiaStickySidebar" class, the DOM elements are moved around and consequently the DFP ads are removed, since they are created using inline JavaScript (document.write). Cheers!

steelmaiden commented 7 years ago

Hi guys, i have the same problem on my theme https://geek.hr/znanost/

Sidebar ad appears and then quickly disappears. This happens randomly on all browsers, but most often on Edge browser.

Please help me find the fix for this!