WeMakeDevs / wemakedevs-archive

Inspire. Educate. Empower.
https://wemakedevs.org
MIT License
486 stars 318 forks source link

[bug] Links inside Hamburgur Menu are not working properly #246

Closed ghost closed 1 year ago

ghost commented 1 year ago

Describe the bug

fldMQxmBO5

Page not loading after you select an option from ham burger menu

NOTE: Url is updating

To Reproduce

  1. Open WeMakeDevs.org website on Samrtphone browser or use smartphone view on your desktop browser
  2. Tap on Ham Burger menu icon to open Menu
  3. Tap on any of the Options present inside the Ham Burger Menu.
  4. Refresh the page

Expected Behavior

Taping on option should scroll down or up to the respective page

Screenshot/ Video

No response

Additional context

No response

github-actions[bot] commented 1 year ago

Hey Hey! 👋🏻 Thank you so much for raising an issue The maintainers will get back to you soon for discussion over the issue!

In the meantime join our discord server and checkout our YouTube channel

Chandraprakash-Darji commented 1 year ago

@karanrao-github what do you think where error can be?

ghost commented 1 year ago

Correct me if I am wrong, but I guess it javascript

FrozenHearth commented 1 year ago

https://user-images.githubusercontent.com/27160715/209565470-2d64996c-868f-4546-b047-2e85bc019028.mov

The error seems to be here. In Header > Index.jsx file. setOpen is not a function I don't get the same error message in responsive mweb in devtools. Also, for mweb, the scroll listener is not being called properly, I guess. (useWindowScrolling hook)

dharmjoshi236 commented 1 year ago

The error is basically, when we are clicking the nav item in mobile view, the header class is not updating. We need some re-render function which will re-render the nav on the scrollTop value.

Made the function for re-render and now its working..

Below is the video for the same....

https://user-images.githubusercontent.com/60209531/210181502-3cd85056-fc1d-40a0-bd7f-5e1efdf89d7d.mp4

FrozenHearth commented 1 year ago

@dharmjoshi236 Please feel free to raise a PR for the same.