WeMakeDevs / wemakedevs-archive

Inspire. Educate. Empower.
https://wemakedevs.org
MIT License
487 stars 318 forks source link

add new company #366

Closed kunal-kushwaha closed 1 year ago

kunal-kushwaha commented 1 year ago

Add company Clicklabs for our students work at

Screenshot 2023-01-23 at 4 32 48 pm
kirtanchandak commented 1 year ago

Hey, can I work on this issue ?

Prateema1 commented 1 year ago

Add company Clicklabs for our students work at Screenshot 2023-01-23 at 4 32 48 pm

Hi, Can I work on this enhancement?

kirtanchandak commented 1 year ago

Hey, I have added the clicklabs image, but while commiting I am getting a eslint error-

click err

Prateema1 commented 1 year ago

Hey, I have added the clicklabs image, but while commiting I am getting a eslint error-

click err

From the error message, it seems like an extra < token(incomplete HTML tag) might be present in your index.jsx file. Line no: 17. As, I haven't committed to the project yet, I am unaware about the issue.

kirtanchandak commented 1 year ago

I think it's not an extra html tag because when I doing "npm start" the website is running fine and giving me a warning -

Screenshot 2023-01-25 193131

Prateema1 commented 1 year ago

I think it's not an extra html tag because when I doing "npm start" the website is running fine and giving me a warning -

Screenshot 2023-01-25 193131

Hey, Have you fixed the warning? In the Work component's index.jsx file, when we import the images, if the imports are not in sorted order, the warning is by eslint package. You can manually place clickLabs import after Cisco image import or run the auto fix script. Can you try once?

kirtanchandak commented 1 year ago

tried, not working!

Chandraprakash-Darji commented 1 year ago

@kirtanchandak share the code then we can say where is the problem

kirtanchandak commented 1 year ago
import clsx from 'clsx';

import styles from './index.module.css';

import Adobe from '../../../assets/home/adobe.svg';
import Amazon from '../../../assets/home/amazon.svg';
import Cisco from '../../../assets/home/Cisco.svg';
import Clicklabs from '../../../assets/home/Clicklabs.svg';
import Google from '../../../assets/home/google.svg';
import Microsoft from '../../../assets/home/microsoft.svg';
import Razorpay from '../../../assets/home/razorpay.svg';
import Samsung from '../../../assets/home/Samsung.svg';
import Virtusa from '../../../assets/home/virtusa.svg';

const index = () => {
  return (
    <div>
      <div className={clsx('layout', styles.layout)}>
        <h2 className='h1'>Our students work at</h2>
        <hr className={clsx('styled-hr', styles.headingWorkLine)} />
        <div className={styles.workImg}>
          <img className={styles.workGoogle} src={Google} alt='google' />
          <img className={styles.workAmazon} src={Amazon} alt='amazon' />
          <img className={styles.workMicro} src={Microsoft} alt='microsoft' />
          <img className={styles.workAdobe} src={Adobe} alt='adobe' />
          <img className={styles.Samsung} src={Samsung} alt='samsung' />
          <img className={styles.virtusa} src={Virtusa} alt='virtusa' />
          <img className={styles.Cisco} src={Cisco} alt='Cisco' />
          <img className={styles.Razorpay} src={Razorpay} alt='Razorpay' />
          <img className={styles.Clicklabs} src={Clicklabs} alt='Clicklabs' />
        </div>
      </div>
    </div>
  );
};

export default index;
melsonic commented 1 year ago

can i work on this ?

AnuragThePathak commented 1 year ago

@kirtanchandak are you still working on it?

Chandraprakash-Darji commented 1 year ago

@melsonic do you want to do?

melsonic commented 1 year ago

Thanks @AnuragThePathak

GH-aditya commented 1 year ago

Can i work on this

AnuragThePathak commented 1 year ago

@GH-aditya already the PR has been created.