WeMakeDevs / wemakedevs-archive

Inspire. Educate. Empower.
https://wemakedevs.org
MIT License
486 stars 318 forks source link

[bug]Padding bottom of "Join Us" section is way too much #728

Closed aaqib605 closed 1 year ago

aaqib605 commented 1 year ago

Describe the bug

I noticed an issue with the 'Join us' section, where the vertical padding was larger than intended, set at 5rem. After making a simple adjustment and setting only the top padding to 5rem, the design appeared much more appealing and aesthetically pleasing.

To Reproduce

No response

Expected Behavior

Making a simple adjustment and setting only the top padding to 5rem, the design appeared much more appealing and aesthetically pleasing.

Screenshot/ Video

Current padding preview:

Additional context

No response

github-actions[bot] commented 1 year ago

Hey Hey! 👋🏻 Thank you so much for raising an issue. The maintainers will get back to you soon for discussion over the issue! In the meantime join our Discord server and checkout our YouTube channel.

mhdamaan79 commented 1 year ago

I would like to work on this issue, please assign it to me. @siddhant-khisty @Chandraprakash-Darji

aaqib605 commented 1 year ago

I would like to work on this issue, please assign it to me. @siddhant-khisty @Chandraprakash-Darji

I should get to work on this issue if the maintainers @siddhant-khisty @Chandraprakash-Darji find it to be a valuable enhancement.

Chandraprakash-Darji commented 1 year ago

@aaqib605 Share the screenshot

Chandraprakash-Darji commented 1 year ago

Screenshot 2023-08-03 at 10 47 18 AM Padding is standard on top and bottom. Just that iframe height shows that padding bottom is more

aaqib605 commented 1 year ago

Padding Top:

Screenshot 2023-08-03 at 10 50 47 AM

Padding Bottom:

Screenshot 2023-08-03 at 10 50 52 AM

I believe even when the card is expanded, the padding-bottom is still not in sync with padding-top:

Screenshot 2023-08-03 at 11 03 42 AM
Chandraprakash-Darji commented 1 year ago

I am saying that iframe creates an illusion of more padding in the bottom than the top. I think this is not a big issue

aaqib605 commented 1 year ago

Please have a look at how the adjusted padding looks like:

Screenshot 2023-08-05 at 11 06 52 AM

@Chandraprakash-Darji If you find the addition valuable, please assign the issue to me. If not, I'm happy to assist as needed. Your guidance is appreciated.

Chandraprakash-Darji commented 1 year ago

What padding value you have setted???

aaqib605 commented 1 year ago

@Chandraprakash-Darji currently padding top and bottom is set to 5rem. By setting only the padding top to 5rem makes the design look good.

Chandraprakash-Darji commented 1 year ago

Closing this issue: Reason: The main problem is the iframe size, If we reduce the iframe size then it will make it scrollable Solution: We are going to implement custom form for these not going to use iframe