WeMakeDevs / wemakedevs-archive

Inspire. Educate. Empower.
https://wemakedevs.org
MIT License
486 stars 316 forks source link

Fix iframe height #794

Closed Susmita-Dey closed 1 year ago

Susmita-Dey commented 1 year ago

Fixes Issue

This PR fixes the following issues:

closes #issue-number

Changes proposed

Here comes all the changes proposed through this PR

Check List (Check all the boxes which are applicable)

Screenshots

Add all the screenshots which support your changes

Summary by CodeRabbit

coderabbitai[bot] commented 1 year ago

Walkthrough

This pull request primarily focuses on enhancing the responsiveness and visual appeal of iframes in two components, Register and NewsLetter. The changes include adjustments to iframe height and overflow properties, and removal of scroll bars.

Changes

File Path Summary
.../IndividualWebinar/Register.jsx Updated iframeHeight state's initial value from 700 to 750. Adjusted height based on window width. Added overflow: hidden to iframe style for improved appearance.
.../layout/JoinUs/NewsLetter.jsx Removed scroll property from iframe style object, resulting in the iframe not having a scroll bar.

🐇💻

In the land of code, where the brackets lie,

Two iframes stood tall, reaching for the sky.

Their heights adjusted, their scrolls concealed,

A smoother user experience, this PR revealed.

So here's to the coder, with vision so bright,

Making interfaces a delightful sight! 🎉🥕

Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - Mention `@coderabbitai` in any *review comment* for bot assistance. - Note: Review comments are made on code diffs or files, not on the PR overview. ### Pause Incremental Reviews - Insert `@coderabbitai: ignore` in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
livecycle[bot] commented 1 year ago

kunal

Your Livecycle playground is ready 🎉.

Playground version up to date (f2d018c0f83e41566472cda42433714714884452)

Invite team members and start collaborating 💪

Check the box and click "invite" to invite collaborators

invite

Click here to invite the rest of your team.