WeMakeDevs / wemakedevs-archive

Inspire. Educate. Empower.
https://wemakedevs.org
MIT License
486 stars 316 forks source link

[bug] Website Link still open on the Same Tab. #809

Closed Pravesh-Sudha closed 1 year ago

Pravesh-Sudha commented 1 year ago

Describe the bug

I submitted a PR for opening the link of WeMakeDevs website on a new Page, though PR has been merged but still when you click on the WeMakeDevs logo or Visit text in the README.md file, it opens the website on the same page rather than a new tab.

To Reproduce

  1. Go to READMEmd
  2. Click on WeMakeDevs logo or Visit text
  3. See the website on the same tab

Expected Behavior

The Website Should open on New Tab.

Screenshot/ Video

No response

Additional context

No response

github-actions[bot] commented 1 year ago

Hey Hey! 👋🏻 Thank you so much for raising an issue. The maintainers will get back to you soon for discussion over the issue! In the meantime join our Discord server and checkout our YouTube channel.

Vijaykv5 commented 1 year ago

I would love to work on this issue

Pravesh-Sudha commented 1 year ago

What would be your approach to solve it...

Vijaykv5 commented 1 year ago

May be adding {:target="_blank"} will work @Pravesh-Sudha

Pravesh-Sudha commented 1 year ago

@Vijaykv5 I have tried that, you can see the Code format of README.md file

malivinayak commented 1 year ago

What would be your approach to solve it...

I have an solution but it need one extra redirection I am add img with solution below kindly check it by clicking on it

malivinayak commented 1 year ago

I have an solution but it need one extra redirection I am add img with solution below kindly check it by clicking on it

After redirection in new tab it will give the repo tab back in original place

malivinayak commented 1 year ago

I have an solution but it need one extra redirection I am add img with solution below kindly check it by clicking on it

After redirection in new tab it will give the repo tab back in original place

@Pravesh-Sudha If you like the solution kindly assign me this issue I will make PR

Pravesh-Sudha commented 1 year ago

That's great @malivinayak, I don't have the authority to assign issue, one of the maintainers will assign you the issue. stay tuned :)

malivinayak commented 1 year ago

That's great @malivinayak, I don't have the authority to assign issue, one of the maintainers will assign you the issue. stay tuned :)

Thank You Meantime I will start fixing issue and create PR

Chandanmali commented 1 year ago

@Pravesh-Sudha can you assign me this issue

malivinayak commented 1 year ago

Thank You Meantime I will start fixing issue and create PR

PR is created kindly check and suggest any changes if needed

AnuragThePathak commented 1 year ago

It is not possible https://stackoverflow.com/questions/41915571/open-link-in-new-tab-with-github-markdown-using-target-blank