search

WePays / WePay

a web application for those who need to coordinate paying for a group.
http://wepays.herokuapp.com
MIT License
5 stars 0 forks source link

Still some questionable requirements #157

Closed jbrucker closed 1 year ago

jbrucker commented 1 year ago

This is a continuous of #153.

Do you really need 'wheel'? For what? wheel is used for creating "wheels" and setuptools.

Packages that are needed to run tests, but not needed to run the app normally, should not be included in requirements.txt.

So, do you need selenium to run the app? Or just for testing?

Packaged needed only for testing can either be added explicitly in your Action scripts on Github (or whatever C.I. server you use), or put them in a separate testing-requirements file.

Tezigudo commented 1 year ago

I didnt really need wheel, the reason that I put it in requirements.txt because I see the messagee below while installing requirements on my virtual env

image

I think that install selenium/(package that need to test) seperately in GitHub Action/Action script are better as you think.