[Diagnostics] Prevent thread explosion

WeTransfer / Diagnostics

Allow users to easily share Diagnostics with your support team to improve the flow of fixing bugs.

MIT License

933 stars 53 forks source link

[Diagnostics] Prevent thread explosion #106

Closed AvdLee closed 2 years ago

AvdLee commented 2 years ago

Not sure if this is actually a problem but we'll have to look into it.

Related resources:

CocoaLumberjack logging: https://github.com/CocoaLumberjack/CocoaLumberjack/blob/master/Sources/CocoaLumberjack/DDLog.m
SwiftyBeaver: https://github.com/SwiftyBeaver/SwiftyBeaver/blob/master/Sources/BaseDestination.swift
libdispatch efficiency tips

AvdLee commented 2 years ago

This turns out to not be caused by Diagnostics. The thread around the log is initiated from RocketSim itself. I tried reproducing this in the Diagnostics Example app using DispatchQueue.concurrentPerform and a regular for loop, not ending up in any issues.