Catch obj-c exception, remove unneeded dispatch

WeTransfer / Diagnostics

Allow users to easily share Diagnostics with your support team to improve the flow of fixing bugs.

MIT License

933 stars 53 forks source link

Catch obj-c exception, remove unneeded dispatch #116

Closed AvdLee closed 2 years ago

AvdLee commented 2 years ago

FileHandles can potentially throw exceptions that aren't catchable by Swift. I experienced this by detaching/attaching the debugger. I decided to add a small dependency to catch this and at least prevent apps from crashing.

Another small improvement removes an unnecessary dispatch since we dispatch again within the following method.

wetransferplatform commented 2 years ago

	Messages
:book:	View more details on Bitrise
:book:	DiagnosticsTests: Executed 30 tests (0 failed, 0 retried, 0 skipped) in 0.392 seconds

Code Coverage Report

Name	Coverage
Diagnostics	73.68%	⚠️

Generated by :no_entry_sign: Danger Swift against 69c7355a2f9c4c49cf0a7ecd069c29ce2d3b1b71

wetransferplatform commented 2 years ago

Congratulations! :tada: This was released as part of Release 4.0.0 :rocket:

Generated by GitBuddy