search

WeTransfer / Diagnostics

Allow users to easily share Diagnostics with your support team to improve the flow of fixing bugs.
MIT License
933 stars 53 forks source link

Fix HTML encoding #123

Closed AvdLee closed 1 year ago

AvdLee commented 1 year ago

We supported printing HTML in logs, but that often resulted in our Diagnostics reports breaking since nothing was stopping users from printing <link ...css> as well.

I tried writing a solution to enable certain tags like <a> for example, but I couldn't find a solution without adding an extra dependency to the project. I decided it's not worth adding that for now and instead ensured all HTML is encoded.

Fixes #120

wetransferplatform commented 1 year ago
Messages
:book: View more details on Bitrise
:book: DiagnosticsTests: Executed 33 tests (0 failed, 0 retried, 0 skipped) in 0.608 seconds

SwiftLint found issues

Severity File Reason
Warning LogsReporterTests.swift:34 Line should be 140 characters or less: currently 157 characters (line_length)

Code Coverage Report

Name Coverage
Diagnostics 70.85% ⚠️

Generated by :no_entry_sign: Danger Swift against ee58a0cf5ffe6c2847c0ec5fe61cf2c0c23041b9