Closed AvdLee closed 1 year ago
Messages | |
---|---|
:book: | View more details on Bitrise |
:book: | No tests found for the current changes in build/reports |
Generated by :no_entry_sign: Danger Swift against e76aef476b440fe090e32dabd8731814b1bec47d
Looks good. Any reason this is merged into the macOS support branch rather than the main branch?
I continued development on where I left of during my RocketSim journey yesterday evening!
Running Diagnostics on iOS 16 resulted in a deadlock since checking for system available space results in system logs being triggered on iOS 16 and up. Since we capture system logs, we would try to log them again, check for system space, triggering another system log. Since we capture system logs, we would try to log them again, check for system space, triggering another system log. Since we capture system logs, we would try to log them again, check for system space, triggering another system log. Since we capture system logs, we would try to log them again, check for system space, triggering another system log.
I added a threshold to ensure that we only check for free disk space periodically, solving this issue.
Furthermore:
optimistic
free size instead ofimportantUsage
since our logs are not as crucial as other user content. Secondly, I rather am on the safe side, andoptimistic
returns a lower number