WeTransfer / Diagnostics

Allow users to easily share Diagnostics with your support team to improve the flow of fixing bugs.
MIT License
933 stars 53 forks source link

Fix infinite loop happening on iOS 16 devices #128

Closed AvdLee closed 1 year ago

AvdLee commented 1 year ago

Running Diagnostics on iOS 16 resulted in a deadlock since checking for system available space results in system logs being triggered on iOS 16 and up. Since we capture system logs, we would try to log them again, check for system space, triggering another system log. Since we capture system logs, we would try to log them again, check for system space, triggering another system log. Since we capture system logs, we would try to log them again, check for system space, triggering another system log. Since we capture system logs, we would try to log them again, check for system space, triggering another system log.

I added a threshold to ensure that we only check for free disk space periodically, solving this issue.

Furthermore:

wetransferplatform commented 1 year ago
Messages
:book: View more details on Bitrise
:book: No tests found for the current changes in build/reports

Generated by :no_entry_sign: Danger Swift against e76aef476b440fe090e32dabd8731814b1bec47d

AvdLee commented 1 year ago

Looks good. Any reason this is merged into the macOS support branch rather than the main branch?

I continued development on where I left of during my RocketSim journey yesterday evening!