search

WeTransfer / Diagnostics

Allow users to easily share Diagnostics with your support team to improve the flow of fixing bugs.
MIT License
933 stars 53 forks source link

Fix macCatalyst support #131

Closed mikakruschel closed 1 year ago

mikakruschel commented 1 year ago

Because CTCellularData is unavailable for macCatalyst, I added !targetEnvironment(macCatalyst) to the already existing #if os(iOS) checks.

wetransferplatform commented 1 year ago
Fails
:no_entry_sign: Build service could not create build operation: internal error: could not generate PIF because the workspace has not finished loading or is still waiting for package resolution
Messages
:book: View more details on Bitrise
:book: DiagnosticsTests: Executed 33 tests (0 failed, 0 retried, 0 skipped) in 1.014 seconds

SwiftLint found issues

Severity File Reason
Warning SmartInsightsReporter.swift:51 Lines should not have trailing whitespace. (trailing_whitespace)

Code Coverage Report

Name Coverage
Diagnostics 71.81% ⚠️

Generated by :no_entry_sign: Danger Swift against b9ae40337e8d9b5eb3fdabfb7328ed3ec07c0bdd

AvdLee commented 1 year ago

Thanks, this makes a lot of sense!

wetransferplatform commented 1 year ago

Congratulations! :tada: This was released as part of Release 4.3.0 :rocket:

Generated by GitBuddy