Closed antranapp closed 1 year ago
This PR is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days.
Oh, one more thing. We've been requiring signed commits for a while. Can you rebase and sign your commits by chance, @antranapp? Let me know if that is something you'd need assistance with.
@BasThomas I have signed my commit and force push again.
Messages | |
---|---|
:book: | DiagnosticsTests: Executed 33 tests (0 failed, 0 retried, 0 skipped) in 10.779 seconds |
:book: | View more details on Bitrise |
Name | Coverage | |
---|---|---|
Diagnostics | 70.37% | ⚠️ |
Severity | File | Reason |
---|---|---|
Warning | MFMailComposeViewControllerTests.swift:10 | Imports should be sorted. (sorted_imports ) |
Warning | MFMailComposeViewControllerTests.swift:26 | Lines should not have trailing whitespace. (trailing_whitespace ) |
Warning | MFMailComposeViewControllerTests.swift:35 | A 'type_method' should not be placed amongst the type content(s) 'initializer,instance_property'. (type_contents_order ) |
Warning | SmartInsightsReporter.swift:56 | Prefer reduce(into:_:) over reduce(_:_:) for copy-on-write types (reduce_into ) |
Warning | UpdateAvailableInsightTests.swift:41 | Line should be 140 characters or less: currently 157 characters (line_length ) |
Warning | UpdateAvailableInsightTests.swift:54 | Line should be 140 characters or less: currently 157 characters (line_length ) |
Warning | UpdateAvailableInsightTests.swift:67 | Line should be 140 characters or less: currently 157 characters (line_length ) |
Warning | UpdateAvailableInsightTests.swift:10 | Imports should be sorted. (sorted_imports ) |
Warning | UpdateAvailableInsightTests.swift:11 | Imports should be sorted. (sorted_imports ) |
Warning | UpdateAvailableInsight.swift:24 | Use shorthand syntax for optional binding (shorthand_optional_binding ) |
Warning | UpdateAvailableInsight.swift:32 | Use shorthand syntax for optional binding (shorthand_optional_binding ) |
Warning | UpdateAvailableInsight.swift:43 | Use shorthand syntax for optional binding (shorthand_optional_binding ) |
Warning | UpdateAvailableInsight.swift:59 | Use shorthand syntax for optional binding (shorthand_optional_binding ) |
Warning | UpdateAvailableInsight.swift:48 | Lines should not have trailing whitespace. (trailing_whitespace ) |
Generated by :no_entry_sign: Danger Swift against 09f542d34960705041ed93c8a694caa752b90128
@antranapp thanks for your contribution!
Awesome, thanks again @antranapp and @AvdLee for merging! :)
Congratulations! :tada: This was released as part of Release 4.4.0 :rocket:
Generated by GitBuddy
We would like to integrate this great package into our app but our app is still supporting iOS 11+.
It looks like that the main functionality of the package is available for iOS 11, only a default SmartInsight requires iOS 13+ due to Combine
I have added some availability checks for that SmartInsight and set the minimum iOS platform version to 11.