Fix: unblock building for VisionOS Simulator

WeTransfer / Diagnostics

Allow users to easily share Diagnostics with your support team to improve the flow of fixing bugs.

MIT License

933 stars 53 forks source link

Fix: unblock building for VisionOS Simulator #155

Closed pgorrindo closed 9 months ago

pgorrindo commented 10 months ago

When building for the VisionOS simulator, Xcode throws errors on availability of CoreTelephony. This PR conditionally imports CoreTelephony.

wetransferplatform commented 10 months ago

	Messages
:book:	DiagnosticsTests: Executed 33 tests (0 failed, 0 retried, 0 skipped) in 10.219 seconds
:book:	Slowest test: DiagnosticsReporterTests/testReportingChapters() (2.017s)
:book:	Slowest test: DiagnosticsReporterTests/testWithSmartInsightsProviderReturningExtraInsights() (2.010s)
:book:	Slowest test: DiagnosticsReporterTests/testWithSmartInsightsProviderReturningNoExtraInsights() (2.005s)
:book:	View more details on Bitrise

Code Coverage Report

Name	Coverage
Diagnostics	63.61%	⚠️

Generated by :no_entry_sign: Danger Swift against cced7c25aea1c84706bf954c87a8b0e1b96ee7d9

pgorrindo commented 10 months ago

@pgorrindo, before merging this in, could you please go over the SwiftLint found issues section in the comment above and fix the warnings? 🙏

done, thanks!

AvdLee commented 10 months ago

@pgorrindo thanks for your contribution 💪

pgorrindo commented 9 months ago

hi @peagasilva et al - looks like auto-merge is blocked because my commits weren't signed 🤦 -- apologies, I've been fiddling with 1Password's CLI lately and that has messed up my normal GH auth. Any chance one of you with admin privs could manually merge this in? thanks in advance!

AvdLee commented 9 months ago

@pgorrindo we can't manually merge this in, unfortunately. However, there's a way to recommit with signed commits:

git rebase --exec 'git commit --amend --no-edit -n -S' master
git push --force

You can read more about setting up signed commits here.

pgorrindo commented 9 months ago

thanks all, and sorry for the hassle 😇 -- @AvdLee my commits are signed now -- and it looks like all auto-merge criteria are fulfilled. maybe Bitrise needs to be re-triggered?

wetransferplatform commented 3 months ago

Congratulations! :tada: This was released as part of Release 4.6.0 :rocket:

Generated by GitBuddy