search

WeTransfer / Diagnostics

Allow users to easily share Diagnostics with your support team to improve the flow of fixing bugs.
MIT License
933 stars 53 forks source link

[TMOB 5114] Log failures happening during log reading #165

Closed AvdLee closed 3 months ago

AvdLee commented 4 months ago

There have been instances where logs wouldn't be readable, failing with:

Parsing the log failed

Since we did not log any related failures, it's hard to conclude what went wrong. This PR enables logging thrown errors so we can better debug this in the future.

Note: often a regeneration/retry solved the issue for users.

wetransferplatform commented 4 months ago
Warnings
:warning: Consider to place some `MARK:` lines for Sources/Logging/Loggable.swift, which is over 300 lines big.
Messages
:book: DiagnosticsTests: Executed 33 tests (0 failed, 0 retried, 0 skipped) in 10.296 seconds
:book: Slowest test: DiagnosticsReporterTests/testReportingChapters() (2.036s)
:book: Slowest test: DiagnosticsReporterTests/testWithoutProvidingSmartInsightsProvider() (2.014s)
:book: Slowest test: DiagnosticsReporterTests/testWithSmartInsightsProviderReturningNoExtraInsights() (2.010s)
:book: View more details on Bitrise

Code Coverage Report

Name Coverage
Diagnostics 64.18% ⚠️

Generated by :no_entry_sign: Danger Swift against 45a56edba2ce4e69a90fa39b2df1bf41145123a8

wetransferplatform commented 3 months ago

Congratulations! :tada: This was released as part of Release 4.6.0 :rocket:

Generated by GitBuddy