search

WeTransfer / Diagnostics

Allow users to easily share Diagnostics with your support team to improve the flow of fixing bugs.
MIT License
960 stars 58 forks source link

Adds swift 4.0 support to the framework #22

Closed mustiikhalil closed 4 years ago

mustiikhalil commented 4 years ago

The following PR will fix the issue with if let space = try? URL(fileURLWithPath: NSHomeDirectory() as String).resourceValues(forKeys: [URLResourceKey.volumeAvailableCapacityForImportantUsageKey]).volumeAvailableCapacityForImportantUsage is still an resolving into an optional in swift 4.2 whereas swift 5 it's a normal Uint64

ghost commented 4 years ago
2 Errors
:no_entry_sign: Any changes to code should be reflected in the Changelog. Please consider adding a note there.
:no_entry_sign: Tests have failed, see below for more information.
1 Message
:book: Tests: Executed 15 tests, with 6 failures (0 unexpected) in 0.060 (0.068) seconds

Tests:

Classname Name
DiagnosticsReporterTests testCSSMinify()
DiagnosticsReporterTests testHeaderGeneration()
DiagnosticsReporterTests testHTMLGeneration()
DiagnosticsReporterTests testReportingChapters()
LogsReporterTests testErrorLog()
LogsReporterTests testMessagesLog()

Current coverage for Diagnostics.framework is 8.05%

Files changed - -
UIDeviceExtensions.swift 0.00% :skull:

Powered by xcov

Generated by :no_entry_sign: Danger

AvdLee commented 4 years ago

Thanks for your contribution! Added my feedback inline 🙂

mustiikhalil commented 4 years ago

@AvdLee ~should I also add it to SPM? or should I keep the SPM version swift 5 since the issue would be dominant only on CocoaPods~

Sorry I completely misunderstood what you meant in the feedback