WeTransfer / Diagnostics

Allow users to easily share Diagnostics with your support team to improve the flow of fixing bugs.
MIT License
933 stars 53 forks source link

fix: save to desktop not working when Diagnostics directory not found #26

Closed mustiikhalil closed 4 years ago

mustiikhalil commented 4 years ago

The following PR fixes the an issue where the Diagnostics file is not created, since there is no Directory called Diagnostics in the desktop

ghost commented 4 years ago
1 Error
:no_entry_sign: Any changes to code should be reflected in the Changelog. Please consider adding a note there.
1 Message
:book: Tests: Executed 15 tests, with 0 failures (0 unexpected) in 0.242 (0.286) seconds

Current coverage for Diagnostics.framework is 73.18%

Files changed - -
DiagnosticsReport.swift 0.00% :skull:

Powered by xcov

Generated by :no_entry_sign: Danger

AvdLee commented 4 years ago

I decided to rewrite it a bit simpler in this PR: https://github.com/WeTransfer/Diagnostics/pull/31

Closing this one in favor of this PR. Thanks a lot for pointing this out and your contribution!