WeTransfer / Diagnostics

Allow users to easily share Diagnostics with your support team to improve the flow of fixing bugs.
MIT License
933 stars 53 forks source link

min deployment target iOS 10.0 #43

Closed sairamkotha closed 4 years ago

sairamkotha commented 4 years ago

Changelog

  1. make minimum deployment to iOS 10.0 to podspec.
  2. Json serialization sortedKeys options remove for iOS 10.

Fixes #42

ghost commented 4 years ago
1 Message
:book: Tests: Executed 17 tests, with 0 failures (0 unexpected) in 0.144 (0.364) seconds

Current coverage for Diagnostics.framework is 76.89%

Files changed - -
UserDefaultsReporter.swift 95.00% :white_check_mark:

Powered by xcov

Generated by :no_entry_sign: Danger

sairamkotha commented 4 years ago

Thanks @AvdLee 👍

davidsteppenbeck commented 4 years ago

@sairamkotha @AvdLee This is just an observation, but I noticed in file Package.swift (L9) the minimum iOS version is still listed as v11.

sairamkotha commented 4 years ago

@davidsteppenbeck Thanks for pointing out. I forgot to change that minimum version.