Memory leaks in DiagnosticsLogger.handlePipeNotification

WeTransfer / Diagnostics

Allow users to easily share Diagnostics with your support team to improve the flow of fixing bugs.

MIT License

933 stars 53 forks source link

Memory leaks in DiagnosticsLogger.handlePipeNotification #65

Closed tomislav closed 4 years ago

tomislav commented 4 years ago

I'm getting memory leaks DiagnosticsLogger.handlePipeNotification. I'm not sure if this is an actual leak or the NSData object being created is being added to an autorelease pool. Does anyone else experience this?

AvdLee commented 4 years ago

I found out that this is caused by the readInBackgroundAndNotify. I've been able to solve this, a PR is coming up!

ghost commented 4 years ago

The pull request #68 that closed this issue was merged and released as part of Release 1.7.0 :rocket: Please let us know if the functionality works as expected as a reply here. If it does not, please open a new issue. Thanks!

Generated by GitBuddy

tomislav commented 4 years ago

@AvdLee Thank you. I can confirm that the memory leaks are gone in 1.7.0.

I'm using Diagnostics for Bluelane. It really helped me figure out some obscure bugs by having users send their logs.

AvdLee commented 4 years ago

That's great, @tomislav! Thanks again for reporting in, it caused quite a few bugs apparently in our Share Extension due to memory issues 🙂