Fix memory leak in readInBackgroundAndNotify method

WeTransfer / Diagnostics

Allow users to easily share Diagnostics with your support team to improve the flow of fixing bugs.

MIT License

953 stars 55 forks source link

Closed AvdLee closed 4 years ago

AvdLee commented 4 years ago

In the process of fixing #65 I've been optimizing our code a bit.

[x] The queue is now using an autoreleasepool to make sure we release all memory correctly
[x] Although used as a singleton we were retaining self quite a bit. Fixed this
[x] We're no longer using the readInBackgroundAndNotify method that was causing a memory leak. Instead, the readabilityHandler allows us to read new log values.

Before	After

Fixes #65

ghost commented 4 years ago

	Messages
:book:	View more details on Bitrise
:book:	Diagnostics: Executed 19 tests, with 0 failures (0 unexpected) in 0.235 (0.550) seconds

File	Coverage
DiagnosticsLogger.swift	59.69%	✅

Generated by :no_entry_sign: Danger Swift against 1ebaf8cae80bd0230b8938eaebf7cadcf12bdb93

ghost commented 4 years ago

Congratulations! :tada: This was released as part of Release 1.7.0 :rocket:

Generated by GitBuddy