search

WeTransfer / Diagnostics

Allow users to easily share Diagnostics with your support team to improve the flow of fixing bugs.
MIT License
933 stars 53 forks source link

About assertionFailure #74

Closed longjianjiang closed 3 years ago

longjianjiang commented 3 years ago

Is there necessary to use assertionFailure on unexpected condition at DiagnosticLogger.swift. May be use print more friendly.

github-actions[bot] commented 3 years ago

This issue is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days.

longjianjiang commented 3 years ago

@AvdLee

AvdLee commented 3 years ago

@longjianjiang assertion failures help during debugging. Whenever they're triggered it means that the logger is not setup correctly.

Note that assertion failures are not triggered in a release build so they would never cause any harm to end-users.

Let me know if that answers your question!

longjianjiang commented 3 years ago

Thanks! @AvdLee