search

WeTransfer / Diagnostics

Allow users to easily share Diagnostics with your support team to improve the flow of fixing bugs.
MIT License
933 stars 53 forks source link

native (aka non-catalyst) macOS support added #75

Closed JulianKahnert closed 3 years ago

JulianKahnert commented 3 years ago

Hi, first of all: thank you for this awesome framework! 🙂

I want to use it with a non-catalyst app and added a enum Device that wraps the os specific information. What do you think of this solution?

wetransferplatform commented 3 years ago
Fails
:no_entry_sign: Failed to get the coverage - Error: The data couldn’t be read because it isn’t in the correct format.
:no_entry_sign: error: Build input file cannot be found: '/Users/vagrant/git/Sources/Extensions/UIDeviceExtensions.swift' (in target 'Diagnostics' from project 'Diagnostics')
Warnings
:warning: **Sources/DiagnosticsLogger.swift#L176** - It is safer to use weak instead of unowned
Messages
:book: View more details on Bitrise

Generated by :no_entry_sign: Danger Swift against f07a783e0fe4124b9d7bbce717e23766d096efe9

JulianKahnert commented 3 years ago

Hi @AvdLee, I have added a comment and created this macOS example project. 🙂

JulianKahnert commented 3 years ago

Oh I just saw that I have to fix the xcode project file before we can merge this. I have used the Package.swift file before.

AvdLee commented 3 years ago

@JulianKahnert thanks for the readme update! I don't think we need an example project with your example code inside the readme. I'm going to merge this in!

JulianKahnert commented 3 years ago

@AvdLee sry for being not precise. The current master branch version fails to build, because I have not updated the Diagnostics.xcodeproj, which is also indicated by this error:

error: Build input file cannot be found: '/Users/vagrant/git/Sources/Extensions/UIDeviceExtensions.swift' (in target 'Diagnostics' from project 'Diagnostics')

https://github.com/JulianKahnert/Diagnostics/commit/cf2445c33754a4c0ca8f9a42dc55c05388f02f5d will fix the problem. But since the PR is already merged, the changes do not appear here.

JulianKahnert commented 3 years ago

I have cherry picked the changes and created https://github.com/WeTransfer/Diagnostics/pull/76 . With that PR merged, the problem should be fixed.

wetransferplatform commented 3 years ago

Congratulations! :tada: This was released as part of Release 1.8.0 :rocket:

Generated by GitBuddy