search

WeTransfer / Diagnostics

Allow users to easily share Diagnostics with your support team to improve the flow of fixing bugs.
MIT License
933 stars 53 forks source link

Prevent setup twice, use file coordinator for increased performance #83

Closed AvdLee closed 3 years ago

AvdLee commented 3 years ago

I've looked at other logging implementation, like SwiftyBeaver and figured we could do a better job in terms of writing performance. Also, it seemed that certain logs weren't written when the app was in the background. The changes in this PR increase chances of logs ending up in the reports by closing the file handle right after writing.

wetransferplatform commented 3 years ago
Warnings
:warning: **Sources/DiagnosticsLogger.swift#L143** - It is safer to use weak instead of unowned
Messages
:book: View more details on Bitrise
:book: Diagnostics: Executed 19 tests, with 0 failures (0 unexpected) in 0.366 (0.597) seconds

DiagnosticsTests.xctest: Coverage: 95.96

File Coverage
LogsReporterTests.swift 97.37% ✅

Diagnostics.framework: Coverage: 77.67

File Coverage
DiagnosticsLogger.swift 62.23% ✅

Generated by :no_entry_sign: Danger Swift against db4c2bd7b4420054b1c915e6bd5cc6c8aad983e3

wetransferplatform commented 3 years ago

Congratulations! :tada: This was released as part of Release 1.9.0 :rocket:

Generated by GitBuddy