search

WeTransfer / Mocker

Mock Alamofire and URLSession requests without touching your code implementation
MIT License
1.12k stars 96 forks source link

Revert breaking change and add `OnRequestHandler` #135

Closed AvdLee closed 2 years ago

AvdLee commented 2 years ago

~Introduced here, reverting it for now. I'll work on an actual better improvement right after.~

I decided to write an actual good solution for it using a new OnRequestHandler, allowing to decode to any decodable type, opening doors for all requested scenarios.

wetransferplatform commented 2 years ago
Warnings
:warning: 'onRequest' is deprecated: Use `onRequestHandler` instead.
:warning: 'onRequest' is deprecated: Use `onRequestHandler` instead.
Messages
:book: View more details on Bitrise
:book: MockerTests: Executed 27 tests (0 failed, 0 retried, 0 skipped) in 1.789 seconds

SwiftLint found issues

Severity File Reason
Error MockingURLProtocol.swift:41 Line should be 160 characters or less: currently 166 characters (line_length)
Error MockingURLProtocol.swift:44 Line should be 160 characters or less: currently 200 characters (line_length)
Warning MockingURLProtocol.swift:101 Line should be 140 characters or less: currently 147 characters (line_length)
Error MockingURLProtocol.swift:105 Line should be 160 characters or less: currently 221 characters (line_length)
Warning Mocker.swift:96 Line should be 140 characters or less: currently 149 characters (line_length)
Warning MockedData.swift:12 Types used for hosting only static members should be implemented as a caseless enum to avoid instantiation. (convenience_type)
Warning Mock.swift:87 Computed properties should declare first the getter and then the setter. (computed_accessors_order)
Error Mock.swift:8 Line should be 160 characters or less: currently 177 characters (line_length)
Warning Mock.swift:49 Line should be 140 characters or less: currently 155 characters (line_length)
Error Mock.swift:81 Line should be 160 characters or less: currently 211 characters (line_length)
Error Mock.swift:84 Line should be 160 characters or less: currently 208 characters (line_length)
Error Mock.swift:95 Line should be 160 characters or less: currently 217 characters (line_length)
Error Mock.swift:104 Line should be 160 characters or less: currently 287 characters (line_length)
Warning Mock.swift:133 Line should be 140 characters or less: currently 142 characters (line_length)
Warning Mock.swift:140 Line should be 140 characters or less: currently 141 characters (line_length)
Error Mock.swift:147 Line should be 160 characters or less: currently 246 characters (line_length)
Error Mock.swift:148 Line should be 160 characters or less: currently 236 characters (line_length)
Warning Mock.swift:159 Line should be 140 characters or less: currently 150 characters (line_length)
Warning Mock.swift:160 Line should be 140 characters or less: currently 153 characters (line_length)
Warning Mock.swift:196 Line should be 140 characters or less: currently 159 characters (line_length)
Error Mock.swift:206 Line should be 160 characters or less: currently 168 characters (line_length)
Warning MockerTests.swift:345 Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
Warning MockerTests.swift:163 Line should be 140 characters or less: currently 151 characters (line_length)
Warning MockerTests.swift:181 Line should be 140 characters or less: currently 149 characters (line_length)
Warning MockerTests.swift:239 Line should be 140 characters or less: currently 154 characters (line_length)
Warning MockerTests.swift:52 Chained function calls should be either on the same line, or one per line. (multiline_function_chains)
Warning MockerTests.swift:71 Chained function calls should be either on the same line, or one per line. (multiline_function_chains)
Warning MockerTests.swift:94 Chained function calls should be either on the same line, or one per line. (multiline_function_chains)
Warning MockerTests.swift:116 Chained function calls should be either on the same line, or one per line. (multiline_function_chains)
Warning MockerTests.swift:149 Chained function calls should be either on the same line, or one per line. (multiline_function_chains)
Warning MockerTests.swift:165 Chained function calls should be either on the same line, or one per line. (multiline_function_chains)
Warning MockerTests.swift:183 Chained function calls should be either on the same line, or one per line. (multiline_function_chains)
Warning MockerTests.swift:206 Chained function calls should be either on the same line, or one per line. (multiline_function_chains)
Warning MockerTests.swift:259 Chained function calls should be either on the same line, or one per line. (multiline_function_chains)
Warning MockerTests.swift:457 Chained function calls should be either on the same line, or one per line. (multiline_function_chains)
Warning MockerTests.swift:491 Chained function calls should be either on the same line, or one per line. (multiline_function_chains)
Warning MockerTests.swift:334 Lines should not have trailing whitespace. (trailing_whitespace)

Code Coverage Report

Name Coverage
Mocker 89.47% ✅

Generated by :no_entry_sign: Danger Swift against bd6da31e7840adb07f611f4c75056caf3c3371da

AvdLee commented 2 years ago

CC @rogerluan and @batuhansk since you've been involved in the previous PR 👌

wetransferplatform commented 2 years ago

Congratulations! :tada: This was released as part of Release 3.0.0 :rocket:

Generated by GitBuddy