wetransferplatform
commented
1 year ago | Fails | |
|---|---|
| :no_entry_sign: | Build service could not create build operation: internal error: could not generate PIF because the workspace has not finished loading or is still waiting for package resolution |
| Warnings | |
|---|---|
| :warning: | 'onRequest' is deprecated: Use `onRequestHandler` instead. |
| :warning: | 'onRequest' is deprecated: Use `onRequestHandler` instead. |
| Messages | |
|---|---|
| :book: | View more details on Bitrise |
| :book: | MockerTests: Executed 27 tests (0 failed, 0 retried, 0 skipped) in 1.646 seconds |
SwiftLint found issues
| Severity | File | Reason |
|---|---|---|
| Warning | Mocker.swift:96 | Line should be 140 characters or less: currently 149 characters (line_length) |
| Error | MockingURLProtocol.swift:41 | Line should be 160 characters or less: currently 166 characters (line_length) |
| Error | MockingURLProtocol.swift:44 | Line should be 160 characters or less: currently 200 characters (line_length) |
| Warning | MockingURLProtocol.swift:101 | Line should be 140 characters or less: currently 147 characters (line_length) |
| Error | MockingURLProtocol.swift:105 | Line should be 160 characters or less: currently 221 characters (line_length) |
| Warning | Mock.swift:87 | Computed properties should declare first the getter and then the setter. (computed_accessors_order) |
| Error | Mock.swift:8 | Line should be 160 characters or less: currently 177 characters (line_length) |
| Warning | Mock.swift:49 | Line should be 140 characters or less: currently 155 characters (line_length) |
| Error | Mock.swift:81 | Line should be 160 characters or less: currently 211 characters (line_length) |
| Error | Mock.swift:84 | Line should be 160 characters or less: currently 208 characters (line_length) |
| Error | Mock.swift:96 | Line should be 160 characters or less: currently 217 characters (line_length) |
| Error | Mock.swift:105 | Line should be 160 characters or less: currently 287 characters (line_length) |
| Warning | Mock.swift:134 | Line should be 140 characters or less: currently 142 characters (line_length) |
| Warning | Mock.swift:141 | Line should be 140 characters or less: currently 141 characters (line_length) |
| Error | Mock.swift:148 | Line should be 160 characters or less: currently 246 characters (line_length) |
| Error | Mock.swift:149 | Line should be 160 characters or less: currently 236 characters (line_length) |
| Warning | Mock.swift:160 | Line should be 140 characters or less: currently 150 characters (line_length) |
| Warning | Mock.swift:161 | Line should be 140 characters or less: currently 153 characters (line_length) |
| Warning | Mock.swift:197 | Line should be 140 characters or less: currently 159 characters (line_length) |
| Error | Mock.swift:207 | Line should be 160 characters or less: currently 168 characters (line_length) |
| Warning | MockedData.swift:12 | Types used for hosting only static members should be implemented as a caseless enum to avoid instantiation. (convenience_type) |
| Warning | MockerTests.swift:345 | Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon) |
| Warning | MockerTests.swift:163 | Line should be 140 characters or less: currently 151 characters (line_length) |
| Warning | MockerTests.swift:181 | Line should be 140 characters or less: currently 149 characters (line_length) |
| Warning | MockerTests.swift:239 | Line should be 140 characters or less: currently 154 characters (line_length) |
| Warning | MockerTests.swift:52 | Chained function calls should be either on the same line, or one per line. (multiline_function_chains) |
| Warning | MockerTests.swift:71 | Chained function calls should be either on the same line, or one per line. (multiline_function_chains) |
| Warning | MockerTests.swift:94 | Chained function calls should be either on the same line, or one per line. (multiline_function_chains) |
| Warning | MockerTests.swift:116 | Chained function calls should be either on the same line, or one per line. (multiline_function_chains) |
| Warning | MockerTests.swift:149 | Chained function calls should be either on the same line, or one per line. (multiline_function_chains) |
| Warning | MockerTests.swift:165 | Chained function calls should be either on the same line, or one per line. (multiline_function_chains) |
| Warning | MockerTests.swift:183 | Chained function calls should be either on the same line, or one per line. (multiline_function_chains) |
| Warning | MockerTests.swift:206 | Chained function calls should be either on the same line, or one per line. (multiline_function_chains) |
| Warning | MockerTests.swift:259 | Chained function calls should be either on the same line, or one per line. (multiline_function_chains) |
| Warning | MockerTests.swift:457 | Chained function calls should be either on the same line, or one per line. (multiline_function_chains) |
| Warning | MockerTests.swift:491 | Chained function calls should be either on the same line, or one per line. (multiline_function_chains) |
| Warning | MockerTests.swift:334 | Lines should not have trailing whitespace. (trailing_whitespace) |
Code Coverage Report
| Name | Coverage | |
|---|---|---|
| Mocker | 88.89% | ✅ |
Generated by :no_entry_sign: Danger Swift against 81a7e082426151f6d9f6d1e20229308a5df93d98
It turned out that Mocker was still using an old project structure, and old CI, and still mentioned CocoaPods. In other words, it clearly needed a clean up.
Even worse: tests failed as SPM could not find newly added files 😅 I'm going to bump to version 3.0.0 after this is merged as well.