WeTransfer / Mocker

Mock Alamofire and URLSession requests without touching your code implementation
MIT License
1.12k stars 96 forks source link

Optional dataType #140

Closed chkpnt closed 1 year ago

chkpnt commented 2 years ago

As discussed in https://github.com/WeTransfer/Mocker/issues/134

I've also added an additional initializer to simplify the mock creation in case a single non-get request has to be mocked.

wetransferplatform commented 2 years ago
Warnings
:warning: Consider to place some `MARK:` lines for Sources/Mocker/Mock.swift, which is over 300 lines big.
Messages
:book: View more details on Bitrise
:book: No tests found for the current changes in build/reports

SwiftLint found issues

Severity File Reason
Warning MockerTests.swift:187 Line should be 140 characters or less: currently 151 characters (line_length)
Warning MockerTests.swift:205 Line should be 140 characters or less: currently 149 characters (line_length)
Warning MockerTests.swift:263 Line should be 140 characters or less: currently 157 characters (line_length)
Warning MockerTests.swift:52 Chained function calls should be either on the same line, or one per line. (multiline_function_chains)
Warning MockerTests.swift:71 Chained function calls should be either on the same line, or one per line. (multiline_function_chains)
Warning MockerTests.swift:94 Chained function calls should be either on the same line, or one per line. (multiline_function_chains)
Warning MockerTests.swift:116 Chained function calls should be either on the same line, or one per line. (multiline_function_chains)
Warning MockerTests.swift:148 Chained function calls should be either on the same line, or one per line. (multiline_function_chains)
Warning MockerTests.swift:173 Chained function calls should be either on the same line, or one per line. (multiline_function_chains)
Warning MockerTests.swift:189 Chained function calls should be either on the same line, or one per line. (multiline_function_chains)
Warning MockerTests.swift:207 Chained function calls should be either on the same line, or one per line. (multiline_function_chains)
Warning MockerTests.swift:230 Chained function calls should be either on the same line, or one per line. (multiline_function_chains)
Warning MockerTests.swift:283 Chained function calls should be either on the same line, or one per line. (multiline_function_chains)
Warning MockerTests.swift:544 Chained function calls should be either on the same line, or one per line. (multiline_function_chains)
Warning MockerTests.swift:578 Chained function calls should be either on the same line, or one per line. (multiline_function_chains)
Warning MockerTests.swift:152 Lines should not have trailing whitespace. (trailing_whitespace)
Warning MockerTests.swift:167 Lines should not have trailing whitespace. (trailing_whitespace)
Warning Mock.swift:93 Computed properties should declare first the getter and then the setter. (computed_accessors_order)
Error Mock.swift:111 Prefer checking isEmpty over comparing count to zero. (empty_count)
Error Mock.swift:8 Line should be 160 characters or less: currently 177 characters (line_length)
Error Mock.swift:38 Line should be 160 characters or less: currently 195 characters (line_length)
Warning Mock.swift:55 Line should be 140 characters or less: currently 155 characters (line_length)
Error Mock.swift:87 Line should be 160 characters or less: currently 211 characters (line_length)
Error Mock.swift:90 Line should be 160 characters or less: currently 208 characters (line_length)
Error Mock.swift:101 Line should be 160 characters or less: currently 217 characters (line_length)
Error Mock.swift:110 Line should be 160 characters or less: currently 297 characters (line_length)
Warning Mock.swift:116 Line should be 140 characters or less: currently 152 characters (line_length)
Warning Mock.swift:156 Line should be 140 characters or less: currently 141 characters (line_length)
Error Mock.swift:159 Line should be 160 characters or less: currently 171 characters (line_length)
Warning Mock.swift:178 Line should be 140 characters or less: currently 141 characters (line_length)
Warning Mock.swift:185 Line should be 140 characters or less: currently 142 characters (line_length)
Error Mock.swift:186 Line should be 160 characters or less: currently 246 characters (line_length)
Warning Mock.swift:204 Line should be 140 characters or less: currently 141 characters (line_length)
Error Mock.swift:206 Line should be 160 characters or less: currently 171 characters (line_length)
Error Mock.swift:211 Line should be 160 characters or less: currently 256 characters (line_length)
Warning Mock.swift:234 Line should be 140 characters or less: currently 150 characters (line_length)
Error Mock.swift:249 Line should be 160 characters or less: currently 171 characters (line_length)
Warning Mock.swift:253 Line should be 140 characters or less: currently 160 characters (line_length)
Warning Mock.swift:268 Line should be 140 characters or less: currently 141 characters (line_length)
Error Mock.swift:270 Line should be 160 characters or less: currently 171 characters (line_length)
Error Mock.swift:275 Line should be 160 characters or less: currently 262 characters (line_length)
Warning Mock.swift:326 Line should be 140 characters or less: currently 159 characters (line_length)
Error Mock.swift:336 Line should be 160 characters or less: currently 168 characters (line_length)
Warning Mock.swift:42 Lines should not have trailing whitespace. (trailing_whitespace)
Warning Mock.swift:114 Lines should not have trailing whitespace. (trailing_whitespace)
Warning Mock.swift:155 Lines should not have trailing whitespace. (trailing_whitespace)
Warning Mock.swift:199 Lines should not have trailing whitespace. (trailing_whitespace)
Warning Mock.swift:224 Lines should not have trailing whitespace. (trailing_whitespace)
Warning Mock.swift:244 Lines should not have trailing whitespace. (trailing_whitespace)
Warning Mock.swift:263 Lines should not have trailing whitespace. (trailing_whitespace)

Generated by :no_entry_sign: Danger Swift against 3b0bd4ec7e4cd1f39175bab150c4595ef15e9bb5

chkpnt commented 2 years ago

That bot seems to live in the future. 😅

grafik
chkpnt commented 2 years ago

The commits are now signed. :-)

AvdLee commented 1 year ago

@chkpnt thanks for signing the commits, you're almost there! CleanShot 2022-11-15 at 11 27 04@2x

Can you finish that as well? 🙂

chkpnt commented 1 year ago

Now we have 7 public initializers, which all need to be maintained... 🫣

I guess it's time to introduce a builder. (probably out of scope of this PR?)

BasThomas commented 1 year ago

Now we have 7 public initializers, which all need to be maintained... 🫣

I guess it's time to introduce a builder. (probably out of scope of this PR?)

🙈

Yeah, I would say that is out of scope, but an interesting idea!

wetransferplatform commented 10 months ago

Congratulations! :tada: This was released as part of Release 3.0.2 :rocket:

Generated by GitBuddy