search

WeTransfer / WeScan

Document Scanning Made Easy for iOS
MIT License
2.87k stars 561 forks source link

Image size reduction after scanning #100

Closed adityashri16 closed 4 years ago

adityashri16 commented 5 years ago

When image is captured and then flattened , the difference between the original and scanned image is almost double i.e. output image is low quality/size.

Can you please fix or let us know the solution to this? We need more quality images with lesser loss.

Thanks, Aditya

julianschiavo commented 5 years ago

Hey, is there any way to test this easily? Perhaps you can make an example project that displays file sizes of captured images so we can debug this.

adityashri16 commented 5 years ago

Hi ,

Sorry I could not reply earlier. We were debugging more and found out that when we sent the data of image to our servers over a network call, the images were of different or desired size. So it is not an issue for us anymore, It may be an issue with the way we were saving images in gallery.

I just checked the image size in 'completeImageCapture' function of CaptureSessionManager.swift class.

Please check the size of image before line no. 261 and after line 263. The scale function reduces the actual image size. This may be the expected result as some transformations are performed here to fit the image in display rectangle.

Please let me know if this is not an issue, I will close it.

Thanks, Aditya

On Sat, Jan 5, 2019 at 8:40 AM Julian Schiavo notifications@github.com wrote:

Hey, is there any way to test this easily? Perhaps you can make an example project that displays file sizes of captured images so we can debug this.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/WeTransfer/WeScan/issues/100#issuecomment-451622922, or mute the thread https://github.com/notifications/unsubscribe-auth/Areewer7F_G0vIBRG5e208BiXNSoxdFBks5vABeNgaJpZM4ZoN1H .

julianschiavo commented 5 years ago

Hey, I'm not actually a part of the organization that owns this repo - however, you should probablyly keep this open just in case so we/they can make sure it's not actually an issue.

It might be that there is actually some sort of issue here because #101 has the same problem.

adityashri16 commented 5 years ago

Hi,

Sorry, I didn't know. Thanks for letting me know.

keeping it open.

Thanks, Aditya

On Mon, Jan 7, 2019 at 1:28 PM Julian Schiavo notifications@github.com wrote:

Hey, I'm not actually a part of the organization that owns this repo - however, you should probablyly keep this open just in case so we/they can make sure it's not actually an issue.

It might be that there is actually some sort of issue here because #101 https://github.com/WeTransfer/WeScan/issues/101 has the same problem.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/WeTransfer/WeScan/issues/100#issuecomment-451850715, or mute the thread https://github.com/notifications/unsubscribe-auth/AreewZlFMAMST3-Gx3620JWx8ABsyLuNks5vAv4dgaJpZM4ZoN1H .

jcampbell05 commented 5 years ago

I'll see if there is some sort of test we can run for this.

Boris-Em commented 5 years ago

We should probably write unit tests for that. It should be fairly simple.

adityashri16 commented 5 years ago

Hey,

I just signed the petition "Narendra Modi , prime minister : Saving future of 16000 jet airways employees" and wanted to see if you could help by adding your name.

Our goal is to reach 300,000 signatures and we need more support. You can read more and sign the petition here:

http://chng.it/GnTPr9zZ5G

Thanks! aditya

github-actions[bot] commented 4 years ago

This issue is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days.