search

WeTransfer / WeScan

Document Scanning Made Easy for iOS
MIT License
2.87k stars 561 forks source link

Shouldn't completion be called here? #112

Closed valeriyvan closed 5 years ago

valeriyvan commented 5 years ago

https://github.com/WeTransfer/WeScan/blob/3ef8b8e49687fead61be62914d53fee61be3b1d8/WeScan/Common/VisionRectangleDetector.swift#L39

jcampbell05 commented 5 years ago

Yes it should can you submit a PR :) with it calling it with nil

julianschiavo commented 5 years ago

This is fixed in #115 and can be closed 👍