search

WeTransfer / WeScan

Document Scanning Made Easy for iOS
MIT License
2.87k stars 561 forks source link

Embedding with Objective-C. #175

Closed johnmccambridge7 closed 5 years ago

johnmccambridge7 commented 5 years ago

I've found an issue with the setup involving objective-c with the swift library. Inside ImageScannerController.swift the init method is not being called when the scanner is called within Objective-C.

public required init() { let scannerViewController = ScannerViewController() super.init(rootViewController: scannerViewController) navigationBar.tintColor = .black navigationBar.isTranslucent = false self.view.addSubview(blackFlashView) setupConstraints() }

Must be added inside to get this to work.

AvdLee commented 5 years ago

@johnmccambridge7 feel free to open a PR for this!

AvdLee commented 5 years ago

Closing as duplicate of https://github.com/WeTransfer/WeScan/issues/167